Re: [PATCH v1 00/13] perf inject improvements
From: Namhyung Kim
Date: Mon Sep 02 2024 - 14:27:12 EST
On Fri, Aug 16, 2024 at 11:44:29PM -0700, Ian Rogers wrote:
> Fix the existing build id injection by adding sample IDs on to the
> synthesized events. This correctly orders the events and addresses
> issues such as a profiled executable being replaced during its
> execution.
>
> Add a new --mmap2-buildid-all option that rewrites all mmap events as
> mmap2 events containing build IDs. This removes the need for build_id
> events.
>
> Add a new -B option that like --mmap2-buildid-all synthesizes mmap2
> with build id events. With -B the behavior is to do it lazily, so only
> when a sample references the particular map. With system wide
> profiling that synthesizes mmap events for all running processes the
> perf.data file savings can be greater than 50%.
>
> Reduce the memory footprint of perf inject by avoiding creating
> symbols in the callchain, the symbols aren't used during perf inject
> and necessitate the loading of dsos.
>
> Ian Rogers (13):
> perf synthetic-events: Avoid unnecessary memset
> perf map: API clean up
> perf jit: Constify filename argument
> perf dso: Constify dso_id
> perf evsel: Constify evsel__id_hdr_size argument
> perf test: Expand pipe/inject test
> perf inject: Combine build_ids and build_id_all into enum
> perf inject: Combine different mmap and mmap2 functions
> perf inject: Combine mmap and mmap2 handling
> perf inject: Fix build ID injection
> perf inject: Add new mmap2-buildid-all option
> perf inject: Lazy build-id mmap2 event insertion
> perf callchain: Allow symbols to be optional when resolving a
> callchain
For the remaining bits,
Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
Thanks,
Namhyung
>
> tools/perf/builtin-inject.c | 532 ++++++++++++++++++----------
> tools/perf/builtin-top.c | 2 +-
> tools/perf/tests/shell/pipe_test.sh | 103 ++++--
> tools/perf/tests/vmlinux-kallsyms.c | 4 +-
> tools/perf/util/build-id.c | 6 +-
> tools/perf/util/callchain.c | 8 +-
> tools/perf/util/callchain.h | 2 +-
> tools/perf/util/dso.c | 4 +-
> tools/perf/util/dso.h | 4 +-
> tools/perf/util/dsos.c | 12 +-
> tools/perf/util/dsos.h | 2 +-
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/evsel.h | 2 +-
> tools/perf/util/jit.h | 3 +-
> tools/perf/util/jitdump.c | 6 +-
> tools/perf/util/machine.c | 95 ++---
> tools/perf/util/machine.h | 36 +-
> tools/perf/util/map.c | 25 +-
> tools/perf/util/map.h | 22 +-
> tools/perf/util/synthetic-events.c | 103 +++++-
> tools/perf/util/synthetic-events.h | 21 +-
> 21 files changed, 682 insertions(+), 312 deletions(-)
>
> --
> 2.46.0.184.g6999bdac58-goog
>