Re: [PATCH v2 2/3] btrfs: Split remaining space to discard in chunks

From: David Sterba
Date: Mon Sep 02 2024 - 19:41:36 EST


On Tue, Sep 03, 2024 at 08:01:16AM +0930, Qu Wenruo wrote:
>
>
> 在 2024/9/3 06:26, Luca Stefani 写道:
> > Per Qu Wenruo in case we have a very large disk, e.g. 8TiB device,
> > mostly empty although we will do the split according to our super block
> > locations, the last super block ends at 256G, we can submit a huge
> > discard for the range [256G, 8T), causing a super large delay.
> >
> > We now split the space left to discard based the block discard limit
> > in preparation of introduction of cancellation signals handling.
> >
> > Reported-by: Qu Wenruo <wqu@xxxxxxxx>
>
> Well, I'd say who ever reported the original fstrim and suspension
> failure should be the reporter, not me.

Once the patch is finalized I'll add the links to reports but yeah if
they're added when the patches are submitted it's helpful.