Re: [PATCH v3] dma: Trace API
From: Christoph Hellwig
Date: Tue Sep 03 2024 - 03:25:23 EST
On Thu, Aug 29, 2024 at 10:24:52AM -0400, Sean Anderson wrote:
> >> When debugging drivers, it can often be useful to trace when memory gets
> >> (un)mapped for DMA (and can be accessed by the device). Add some
> >> tracepoints for this purpose.
> >>
> >> We use unsigned long long instead of phys_addr_t and dma_addr_t (and
> >> similarly %llx instead of %pa) because libtraceevent can't handle
> >> typedefs.
> >
> > and a __u64 would seem like the better type here.
>
> libtraceevent can't handle typedefs, including u64.
Weird. The xfs trace events which were some of the first ever are full
of typedefs and no one ever complained. And looking at other
trace event definitions they are full of it.
I've added the tracing maintainers to see if we can shed some light
on this issue.