Re: [PATCH net-next v2 5/7] net: phy: microchip_t1s: add support for Microchip's LAN867X Rev.C1

[Simon Horman]

On Mon, Sep 02, 2024 at 08:04:56PM +0530, Parthiban Veerasooran wrote:
> This patch adds support for LAN8670/1/2 Rev.C1 as per the latest
> configuration note AN1699 released (Revision E (DS60001699F - June 2024))
> https://www.microchip.com/en-us/application-notes/an1699
> 
> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@xxxxxxxxxxxxx>

...

> diff --git a/drivers/net/phy/microchip_t1s.c b/drivers/net/phy/microchip_t1s.c

...

> @@ -290,6 +291,58 @@ static int lan867x_check_reset_complete(struct phy_device *phydev)
>  	return 0;
>  }
>  
> +static int lan867x_revc1_config_init(struct phy_device *phydev)
> +{
> +	s8 offsets[2];
> +	int ret;
> +
> +	ret = lan867x_check_reset_complete(phydev);
> +	if (ret)
> +		return ret;
> +
> +	ret = lan865x_generate_cfg_offsets(phydev, offsets);
> +	if (ret)
> +		return ret;
> +
> +	/* LAN867x Rev.C1 configuration settings are equal to the first 9
> +	 * configuration settings and all the sqi fixup settings from LAN865x
> +	 * Rev.B0/B1. So the same fixup registers and values from LAN865x
> +	 * Rev.B0/B1 are used for LAN867x Rev.C1 to avoid duplication.
> +	 * Refer the below links for the comparision.

nit: comparison

     Flagged by checkpatch.pl --codespell

> +	 * https://www.microchip.com/en-us/application-notes/an1760
> +	 * Revision F (DS60001760G - June 2024)
> +	 * https://www.microchip.com/en-us/application-notes/an1699
> +	 * Revision E (DS60001699F - June 2024)
> +	 */