Re: [PATCH 2/3] mm/ksm: Support prctl controlling KSM with pid

[David Hildenbrand]

On 03.09.24 06:13, xu xin wrote:
> Thanks for your reply.
>
> Selection of interface
> ======================
>
> At this point, I have been thinking for a long time, and in order to achieve
> the control of the KSM scanning of an already running process, the current
> prctl PR_SET_MEMORY_MERGE is the most suitable interface. On the one hand,
> it is compatible with the existing KSM PRCTL interface, making it easier
> for users to get used to and adapt to it; On the other hand, it adds prctl
> control over processes that have already been started through PID. Lastly,
> I referred to the PR_SCHED_CORE option of prctl, which also uses arg3 to
> perform operations on tasks pointed to by specific PID.
>
> Anyway, the current way may not necessarily violates "prctl() manipulates
> various aspects of the behavior of the calling thread or process." ,
> becasue we can consider controlling KSM scanning of pid as a behavior of
> the calling thread.

No, it's just wrong. Find something else.

--
Cheers,

David / dhildenb