RE: [PATCH v2] usb: xhci: fixes lost of data for xHCI Cadence Controllers
From: Pawel Laszczak
Date: Tue Sep 03 2024 - 04:24:07 EST
Hi,
>On 30.8.2024 18.45, Michał Pecio wrote:
>> Hi,
>>
>>> Field Rsvd0 is reserved field, so patch should not have impact for
>>> other xHCI controllers.
>> Wait, is this a case of Linux failing to zero-initialize something
>> that should be zero initialized before use (why not explain it as
>> such?), or are you suggesting monkeying with internal xHC data at run
>> time, in area which is known to actually be used by at least one
>implementation?
>>
>
>Patch is monkeying with internal xHC RsvdO field.
>
>
>> There is no mention of Rsvd0 in the xHCI spec, did you mean RsvdO?
>>
>> Reserved and Opaque,
>> For exclusive use by the xHC.
>> Software shall *not* write this, unless allowed by the vendor.
>>
>> Cadence isn't the only xHC vendor...
>>
>
>Makes sense, Pawel Laszczak, could you make this patch Cadence specific.
I understand your concerns. I will prepare new patch.
For this purpose I'm going to add some extra quirk definition.
Thanks
Pawel
>
>Thanks
>Mathias