[PATCH v5 0/7] udmbuf bug fix and some improvements

From: Huan Yang
Date: Tue Sep 03 2024 - 04:44:21 EST


This patchset attempts to fix some errors in udmabuf and remove the
upin_list structure.

By this patchset, udmabuf remove page struct relay, only use
pfn and folios.

Some of this fix just gather the patches which I upload before.

Any patch has passed the udmabuf self-test suite's tests.
Suggested by Kasireddy, Vivek <vivek.kasireddy@xxxxxxxxx>
Patch5 modified the unpin function, therefore running the udmabuf
self-test program in a loop did not reveal any memory leaks.

Notice: Test item 6 maybe requires running the command:
echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages

Changelog
===
v4 -> v5:
Patch1 doc why pre-fault failed not report error.
Patch2 no change
Patch3 update ack tag marked in v4
Patch4 split some change into patch5 and patch7, this only contains
udmabuf pin folio's function
Patch5 add helper init/deini to clean udmabuf struct initialized
Patch6 remove unnecessary code
Patch7 remove reuse folio remove v4 patch4

v3 -> v4:
Patch1 fill vma area with pfn only when true access.
Patch2 no change
Patch3 select VMAP_PFN
Patch4 use function pin each item.
Patch5 use pinned folio array instead udmabuf_folio struct.
v2 -> v3:
Patch1, avoid use page, instead, use pfn, and use vmf_insert_pfn map
suggested-by Kasireddy, Vivek <vivek.kasireddy@xxxxxxxxx>

Patch2, update acked-by Kasireddy, Vivek <vivek.kasireddy@xxxxxxxxx>
And keep the kvcalloc on the same line.

Patch3, avoid use page, instead, use pfn, then use vmap_pfn map

Patch4, split v2 patch4, single update codestyle to keep review
easy.

Patch5, another way to remove udmabuf_folio

---
v1 -> v2:
Patch1, 3 Rectify the improper use of the sg table.
suggested-by Christian König <christian.koenig@xxxxxxx>

Patch2 add acked-by Christian K�nig <christian.koenig@xxxxxxx> which
marked in v1

Patch4
Modify the data structure to restore the use of pages and
correct the misunderstanding of loop conditions such as "pgcnt".
make sure pass self test.

remove v1's patch4

v4
https://lore.kernel.org/all/20240822084342.1574914-1-link@xxxxxxxx/
v3
https://lore.kernel.org/all/20240813090518.3252469-1-link@xxxxxxxx/
v2
https://lore.kernel.org/all/20240805032550.3912454-1-link@xxxxxxxx/
v1
https://lore.kernel.org/all/20240801104512.4056860-1-link@xxxxxxxx/

Huan Yang (7):
udmabuf: pre-fault when first page fault
udmabuf: change folios array from kmalloc to kvmalloc
udmabuf: fix vmap_udmabuf error page set
udmabuf: udmabuf_create pin folio codestyle cleanup
udmabuf: introduce udmabuf init and deinit helper
udmabuf: remove udmabuf_folio
udmabuf: reuse folio array when pin folios

drivers/dma-buf/Kconfig | 1 +
drivers/dma-buf/udmabuf.c | 272 +++++++++++++++++++++++---------------
2 files changed, 166 insertions(+), 107 deletions(-)


base-commit: c79c85875f1af04040fe4492ed94ce37ad729c4d
--
2.45.2