Re: [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property

[Krzysztof Kozlowski]

On 03/09/2024 10:38, Jingyi Wang wrote:
> 
> 
> On 9/3/2024 4:00 PM, Krzysztof Kozlowski wrote:
>> On 03/09/2024 09:30, Jingyi Wang wrote:
>>>
>>>
>>> On 9/3/2024 3:10 PM, Krzysztof Kozlowski wrote:
>>>> On Tue, Sep 03, 2024 at 02:21:29PM +0800, Jingyi Wang wrote:
>>>>> Add a property "num-banks" for errata.
>>>>
>>>> This you said in commit subject and we see in the diff. You *MUST*
>>>> explain why.
>>>>
> Usually the num of LLCC banks is read from hardware, but there is errata
> on some SoCs to get the wrong bank num from LLCC_COMMON_STATUS0. Add a
> property "num-banks" to indicate the accurate data.

You have compatible for that. Anyway, your future patch must clearly
explain the problem in details.

Best regards,
Krzysztof