Re: [PATCH v1 1/1] pinctrl: intel: Constify struct intel_pinctrl parameter

[Andy Shevchenko]

On Tue, Sep 3, 2024 at 7:57 AM Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Mon, Sep 02, 2024 at 05:15:11PM +0300, Andy Shevchenko wrote:
> > -static void __iomem *intel_get_padcfg(struct intel_pinctrl *pctrl,
> > +static void __iomem *intel_get_padcfg(const struct intel_pinctrl *pctrl,
> >                                     unsigned int pin, unsigned int reg)
>
> This is not good. You take const pointer but return non-const inside
> that struct. I don't think we should "change" the constness this way.

I see. I will double check this. Thank you for reviewing this!

> All changes that take const pointer and return scalar are fine, though
> (did not check all of them).



-- 
With Best Regards,
Andy Shevchenko