Re: [PATCH v2 2/2] Loongarch: EDAC driver for loongson memory controller

[Zhao Qunqin]

在 2024/9/3 下午7:29, Krzysztof Kozlowski 写道:
> On 03/09/2024 10:30, Xi Ruoyao wrote:
> > On Tue, 2024-09-03 at 09:58 +0200, Krzysztof Kozlowski wrote:
> > > > > > +	select EDAC_SUPPORT
> > > > > I think you got here comment before. How did you address it?
> > > > I just randomly found a spot, and I will put it at the end(next version
> > > > patch).
> > > No, the comment was different. You must not select user-visible symbols.
> > EDAC_SUPPORT isn't user-visible.  EDAC is and it has been removed.
> Ah, ok, I missed that. Shouldn't this be separate patch with its own
> rationale? Or before this driver there was no EDAC support for Loongson
> at all?

Before this driver there was no EDAC support for Loongson
at all.

Best regards,
Zhao Qunqin.

> Best regards,
> Krzysztof