Re: [PATCH v2 4/8] unicode: Recreate utf8_parse_version()

[Theodore Ts'o]

On Mon, Sep 02, 2024 at 07:55:06PM -0300, André Almeida wrote:
> All filesystems that currently support UTF-8 casefold can fetch the
> UTF-8 version from the filesystem metadata stored on disk. They can get
> the data stored and directly match it to a integer, so they can skip the
> string parsing step, which motivated the removal of this function in the
> first place.
> 
> However, for tmpfs, the only way to tell the kernel which UTF-8 version
> we are about to use is via mount options, using a string. Re-introduce
> utf8_parse_version() to be used by tmpfs.
> 
> This version differs from the original by skipping the intermediate step
> of copying the version string to an auxiliary string before calling
> match_token(). This versions calls match_token() in the argument string.
> 
> utf8_parse_version() was created by 9d53690f0d4 ("unicode: implement
> higher level API for string handling") and later removed by 49bd03cc7e9
> ("unicode: pass a UNICODE_AGE() tripple to utf8_load").
> 
> Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx>

Reviewed-by: Theodore Ts'o <tytso@xxxxxxx>