Re: [PATCH 1/2] mmc: block: add RPMB dependency
From: Ulf Hansson
Date: Tue Sep 03 2024 - 08:39:43 EST
On Mon, 2 Sept 2024 at 17:12, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>
> Prevent build error when CONFIG_RPMB=m and CONFIG_MMC_BLOCK=y by adding
> a dependency to CONFIG_RPMB for CONFIG_MMC_BLOCK block so the RPMB
> subsystem always is reachable if configured. This means that
> CONFIG_MMC_BLOCK automatically becomes compiled as a module if
> CONFIG_RPMB is compiled as a module. If CONFIG_RPMB isn't configured or
> is configured as built-in, CONFIG_MMC_BLOCK will remain unchanged.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409021448.RSvcBPzt-lkp@xxxxxxxxx/
> Fixes: 7852028a35f0 ("mmc: block: register RPMB partition with the RPMB subsystem")
> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Replacing "rpmb: use IS_REACHABLE instead of IS_ENABLED"
> https://lore.kernel.org/lkml/20240902080727.2665235-1-jens.wiklander@xxxxxxxxxx/
> ---
> drivers/mmc/core/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig
> index bf4e29ef023c..14d2ecbb04d3 100644
> --- a/drivers/mmc/core/Kconfig
> +++ b/drivers/mmc/core/Kconfig
> @@ -37,6 +37,7 @@ config PWRSEQ_SIMPLE
> config MMC_BLOCK
> tristate "MMC block device driver"
> depends on BLOCK
> + depends on RPMB || !RPMB
> imply IOSCHED_BFQ
> default y
> help
> --
> 2.34.1
>