Re: [PATCH V6 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

[Andrew Lunn]

On Tue, Sep 03, 2024 at 08:13:58PM +0800, Jijie Shao wrote:
> 
> on 2024/9/3 19:59, Paolo Abeni wrote:
> > On 8/30/24 14:15, Jijie Shao wrote:
> > [...]
> > > +static int hbg_mdio_wait_ready(struct hbg_mac *mac)
> > > +{
> > > +#define HBG_MDIO_OP_TIMEOUT_US        (1 * 1000 * 1000)
> > > +#define HBG_MDIO_OP_INTERVAL_US        (5 * 1000)
> > 
> > Minor nit: I find the define inside the function body less readable than
> > placing them just before the function itself.
> 
> These two macros are only used in this function.
> Is it necessary to move them to the header file?

Put them at the top of the .c file. That is pretty much standard in C.

	Andrew