Re: [PATCH v2 2/3] rtc: support for the Amlogic on-chip RTC

[Krzysztof Kozlowski]

On 03/09/2024 09:00, Xianwei Zhao via B4 Relay wrote:
> From: Yiting Deng <yiting.deng@xxxxxxxxxxx>
> 

...

> +	rtc->map = devm_regmap_init_mmio(&pdev->dev, base, &aml_rtc_regmap_config);
> +	if (IS_ERR(rtc->map)) {
> +		dev_err_probe(&pdev->dev, PTR_ERR(rtc->map), "regmap init failed\n");
> +		return PTR_ERR(rtc->map);

Nothing improved. Read the comment. Use git grep to see how this is done
if the comment is somehow unclear.

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof