Re: [PATCH v5] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals Support
From: Rob Herring (Arm)
Date: Tue Sep 03 2024 - 10:28:14 EST
On Tue, 03 Sep 2024 14:47:20 +0530, Tarang Raval wrote:
> Add following peripherals support for the Emtop i.MX8M Mini Baseboard
>
> * Wi-Fi
> * Audio
> * SD card
> * RTC
> * CAN bus
> * USB OTG
>
> Signed-off-by: Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>
> ---
>
> Changes in v2:
>
> 1. Updated the node name and pinctrl name.
> 2. Removed the 'regulators' container.
> 3. Removed a stray blank line.
> 4. Removed non-existent properties.
> 5. Removed unused node and pinctrl:
> -modem-reset
> -pinctrl_uart1
> 6. Defined the CAN transceiver reset GPIO separately.
>
> Change in v3:
>
> 1. Removed 'can-connector'.
> 2. Use USB connector instead of extcon_usb.
> 3. Changed id-gpio to id-gpios.
> 4. Use Level trigger IRQ in the CAN node.
> 5. Corrected the compatible property of RTC.
> 6. Added blank lines to separate the pinctrl groups.
>
> Changes in v4:
>
> 1. Sorted I2C device nodes by slave address.
> 2. Moved properties above the "status" property in the Wi-Fi node.
>
> Change in v5:
>
> 1. I mistakenly removed <pinctrl-canbus>; it has now been re-added.
> 2. Added Author name
> ---
> .../dts/freescale/imx8mm-emtop-baseboard.dts | 335 ++++++++++++++++++
> 1 file changed, 335 insertions(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y freescale/imx8mm-emtop-baseboard.dtb' for 20240903091720.443091-1-tarang.raval@xxxxxxxxxxxxxxxxx:
arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dtb: /soc@0/bus@30800000/spba-bus@30800000/spi@30830000/can@0: failed to match any schema with compatible: ['microchip,mcp2515']