Re: [net-next PATCH 1/4] octeontx2-pf: Defines common API for HW resources configuration

[Pavan Chebbi]

On Tue, Sep 3, 2024 at 6:11 PM Geetha sowjanya <gakula@xxxxxxxxxxx> wrote:
>
> -
>         /* Assign default mac address */
>         otx2_get_mac_from_af(netdev);
>
> @@ -3118,11 +3141,8 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>         if (test_bit(CN10K_LMTST, &pf->hw.cap_flag))
>                 qmem_free(pf->dev, pf->dync_lmt);
>         otx2_detach_resources(&pf->mbox);
Isn't some of this unwinding/cleanup already moved to the new
function? Looks like duplicate code to me.

> -err_disable_mbox_intr:
>         otx2_disable_mbox_intr(pf);
> -err_mbox_destroy:
>         otx2_pfaf_mbox_destroy(pf);
> -err_free_irq_vectors:
>         pci_free_irq_vectors(hw->pdev);
>  err_free_netdev:
>         pci_set_drvdata(pdev, NULL);
> --
> 2.25.1
>
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature