Re: [PATCH v2 1/3] pmdomain: imx93-pd: replace dev_err() with dev_err_probe()

From: Uwe Kleine-König
Date: Tue Sep 03 2024 - 12:26:42 EST


Hello,

On Sun, Aug 25, 2024 at 04:34:00PM +0200, Dario Binacchi wrote:
> This way, the code becomes more compact, and dev_err_probe() is used in
> every error path of the probe() function.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>

Another improvement worth mentioning is that the new output mentions the
error code returned by clk_bulk_prepare_enable(). If you respin this
series you might want to consider adding that to the commit log. Even
without that added:

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature