Re: [PATCH 1/3] rust: Introduce HAVE_GENERATE_RUST_TARGET config option

From: Miguel Ojeda
Date: Tue Sep 03 2024 - 13:43:45 EST


On Tue, Sep 3, 2024 at 7:15 PM Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> wrote:
>
> +

Spurious line?

> +config HAVE_GENERATE_RUST_TARGET
> + bool
> + depends on HAVE_RUST
> + help
> + This symbol should be selected by an architecture if it
> + supports generating Rust target files with
> + scripts/generate_rust_target.rs.

It should be more like "if it needs" rather than "if it supports",
i.e. the `target.json` is something that should be avoided if
possible, since the goal is to avoid depending on it in the future.

Cheers,
Miguel