Re: [PATCH] docs: rust: fix formatting for kernel::block::mq::Request
From: Francesco Zardi
Date: Tue Sep 03 2024 - 13:57:16 EST
On Tue, Sep 3, 2024 at 12:38 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> On Mon, Sep 2, 2024 at 11:16 PM Francesco Zardi <frazar00@xxxxxxxxx> wrote:
> > Closes: https://github.com/Rust-for-Linux/linux/issues/1108
> >
> > Signed-off-by: Francesco Zardi <frazar00@xxxxxxxxx>
> > Suggested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> If we considered these a fix (I think at least for the first bullet
> point it makes sense to do so), these should probably be (in this
> order, and without blank newlines):
>
> Reported-by:
> Closes:
> Signed-off-by:
>
> But depending on the maintainer they may do this without a v2 when
> picking it up -- it depends on what Andreas wants to do (it could go
> through Block or Rust).
Thank you very much Miguel for the very clear and quick feedback.
I will submit a v2 with the suggested fixes.
Regards,
Francesco