Re: [PATCH v5 2/5] PCI: Check PCI_PM_CTRL instead of PCI_COMMAND in pci_dev_wait()
From: Bjorn Helgaas
Date: Tue Sep 03 2024 - 14:25:26 EST
On Tue, Sep 03, 2024 at 12:31:00PM -0500, Mario Limonciello wrote:
> On 9/3/2024 12:11, Bjorn Helgaas wrote:
> ...
> > 8) The USB4 stack sees the device and assumes it is in D0, but it
> > seems to still be in D3cold. What is this based on? Is there a
> > config read that returns ~0 data when it shouldn't?
>
> Yes there is. From earlier in the thread I have a [log] I shared.
>
> The message emitted is from ring_interrupt_active():
>
> "thunderbolt 0000:e5:00.5: interrupt for TX ring 0 is already enabled"
Right, that's in the cover letter, but I can't tell from this what the
ioread32(ring->nhi->iobase + reg) returned. It looks like this is an
MMIO read of BAR 0, not a config read.
> [log] https://gist.github.com/superm1/cb407766ab15f42f12a6fe9d1196f6fc