[PATCH v2] tools/counter: Close fd when exit
From: zhangjiao2
Date: Tue Sep 03 2024 - 21:43:11 EST
From: zhang jiao <zhangjiao2@xxxxxxxxxxxxxxxxxxxx>
Since fd is not used in the messaging it's better to
close it before printing anything. Ditto for other cases.
Signed-off-by: zhang jiao <zhangjiao2@xxxxxxxxxxxxxxxxxxxx>
---
v1->v2:
Close fd before fprintf.
tools/counter/counter_example.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/counter/counter_example.c b/tools/counter/counter_example.c
index be55287b950f..37569208c235 100644
--- a/tools/counter/counter_example.c
+++ b/tools/counter/counter_example.c
@@ -57,12 +57,14 @@ int main(void)
if (ret == -1) {
+ close(fd);
fprintf(stderr, "Error adding watches[%d]: %s\n", i,
strerror(errno));
return 1;
}
}
ret = ioctl(fd, COUNTER_ENABLE_EVENTS_IOCTL);
if (ret == -1) {
+ close(fd);
perror("Error enabling events");
return 1;
}
@@ -70,11 +72,13 @@ int main(void)
ret = read(fd, event_data, sizeof(event_data));
if (ret == -1) {
+ close(fd);
perror("Failed to read event data");
return 1;
}
if (ret != sizeof(event_data)) {
+ close(fd);
fprintf(stderr, "Failed to read event data\n");
return -EIO;
}
@@ -88,5 +92,6 @@ int main(void)
strerror(event_data[1].status));
}
+ close(fd);
return 0;
}
--
2.33.0