Re: [PATCH v2] kbuild: pahole-version: improve overall checking and error messages

[Masahiro Yamada]

On Tue, Sep 3, 2024 at 1:13 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Mon, Sep 2, 2024 at 6:09 PM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote:
> >
> > +if ! command -v "$@" >/dev/null; then
> > +       echo >&2 "***"
> > +       echo >&2 "*** pahole '$@' could not be found. pahole will not be used."
> > +       echo >&2 "***"
> > +       exit 1
> > +fi
>
> We may not want to print a warning in this case if this case/setup is
> too common, though.




I am fine with your color (in case someone wants
to run it manually?) as long as stderr is suppressed
in Kconfig.

default $(shell,$(srctree)/scripts/pahole-version.sh $(PAHOLE) 2>/dev/null)




scripts/rust_is_available.sh is very verbose, but
we are not annoyed while running Kconfig because the
$(success ) macro suppressed stderr.





-- 
Best Regards
Masahiro Yamada