Re: [f2fs-dev] [PATCH 05/13] f2fs: set inline tail flag when create inode

[Wu Bo]

On Tue, Sep 03, 2024 at 09:50:41AM +0000, Huang Jianan via Linux-f2fs-devel wrote:
> On 2024/9/3 16:54, Wu Bo via Linux-f2fs-devel wrote:
> > [外部邮件] 此邮件来源于小米公司外部，请谨慎处理。若对邮件安全性存疑，请将邮件转发给misec@xxxxxxxxxx进行反馈
> > 
> > Set inline tail flag to enable this feature when new inode is created.
> > Inherit the conditions from inline data.
> > 
> > Signed-off-by: Wu Bo <bo.wu@xxxxxxxx>
> > ---
> >   fs/f2fs/namei.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> > index 38b4750475db..13c295ea19de 100644
> > --- a/fs/f2fs/namei.c
> > +++ b/fs/f2fs/namei.c
> > @@ -315,6 +315,9 @@ static struct inode *f2fs_new_inode(struct mnt_idmap *idmap,
> >          /* Should enable inline_data after compression set */
> >          if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode))
> >                  set_inode_flag(inode, FI_INLINE_DATA);
> > +       /* Inherit the conditions from inline data */
> > +       if (test_opt(sbi, INLINE_TAIL) && f2fs_has_inline_data(inode))
> > +               set_inode_flag(inode, FI_INLINE_TAIL);
> 
> Should f2fs_post_read_required() be checked here, like inline data?

To ensure the conditions for enabling inline tail are the same as for inline
data, I deliberately use the inline data flag to determine whether to enable
the inline tail.

Thanks

> 
> Thanks,
> Jianan
> 
> > 
> >          if (name && !test_opt(sbi, DISABLE_EXT_IDENTIFY))
> >                  set_file_temperature(sbi, inode, name);
> > --
> > 2.35.3
> > 
> > 
> > 
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel