Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

[Dev Jain]

On 9/4/24 03:14, Shuah Khan wrote:
> On 8/30/24 10:29, Dev Jain wrote:
> > On 8/27/24 17:16, Dev Jain wrote:
> > > On 8/27/24 17:14, Shuah Khan wrote:
> > > > On 8/22/24 06:14, Dev Jain wrote:
> > > > > Rename sigaltstack to generic signal directory, to allow adding more
> > > > > signal tests in the future.
> > > >
> > > > Sorry - I think I mentioned I don't like this test renamed. Why are 
> > > > you sending
> > > > this rename still included in the patch series?
> > >
> > > I am not renaming the test, just the directory. The directory name
> > > is changed to signal, and I have retained the name of the test -
> > > sas.c.
> >
> > Gentle ping: I guess there was a misunderstanding; in v5, I was
> > also changing the name of the test, to which you objected, and
> > I agreed. But, we need to change the name of the directory since
> > the new test has no relation to the current directory name,
> > "sigaltstack". The patch description explains that the directory
> > should be generically named.
>
> Right. You are no longer changing the test name. You are still
> changing the directory name. The problem I mentioned stays the
> same. Any fixes to the existing tests in this directory can no
> longer auto applied to stables releases.

I understand your point, but commit baa489fabd01 (selftests/vm: rename
selftests/vm to selftests/mm) is also present. That was a lot bigger change;
sigaltstack contains just one test currently, whose fixes possibly would 
have
to be backported, so I guess it should not be that much of a big problem?

> Other than the desire to rename the directory to generic, what
> other value does this change bring?

Do you have an alternative suggestion as to where I should put my new 
test then;
I do not see what is the value of creating another directory to just include
my test. This will unnecessarily clutter the selftests/ directory with
directories containing single tests. And, putting this in "sigaltstack" 
is just
wrong since this test has no relation with sigaltstack.

>