[PATCH 6/8] perf tools: Separate exclude_hv fallback

From: Namhyung Kim
Date: Wed Sep 04 2024 - 02:42:47 EST


The exclude_hv was added to address branch stack samples on Intel PMUs.
As some other PMUs might not support that, let's separate the bit from
exclude_kernel to make sure it can add the bit only if required.

Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
---
tools/perf/util/evsel.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 6456c28326144528..0de0a72947db3f10 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3389,10 +3389,16 @@ bool evsel__fallback(struct evsel *evsel, struct target *target, int err,
free(evsel->name);
evsel->name = new_name;
scnprintf(msg, msgsize, "kernel.perf_event_paranoid=%d, trying "
- "to fall back to excluding kernel and hypervisor "
- " samples", paranoid);
+ "to fall back to excluding kernel samples", paranoid);
evsel->core.attr.exclude_kernel = 1;
- evsel->core.attr.exclude_hv = 1;
+
+ return true;
+ } else if (err == EACCES && !evsel->core.attr.exclude_hv &&
+ (paranoid = perf_event_paranoid()) > 1) {
+ /* Intel branch stack requires exclude_hv */
+ scnprintf(msg, msgsize, "kernel.perf_event_paranoid=%d, trying "
+ "to fall back to excluding hypervisor samples", paranoid);
+ evsel->core.attr.exclude_hv = 1;

return true;
}
--
2.46.0.469.g59c65b2a67-goog