Re: [PATCH v5 4/4] x86/cacheinfo: Clean out init_cache_level()
From: Ricardo Neri
Date: Wed Sep 04 2024 - 03:24:34 EST
On Mon, Sep 02, 2024 at 09:41:40AM +0200, Andreas Herrmann wrote:
> On Sun, Sep 01, 2024 at 08:09:13PM +0200, Andreas Herrmann wrote:
> > On Mon, Aug 26, 2024 at 10:16:35PM -0700, Ricardo Neri wrote:
> > > init_cache_level() no longer has a purpose on x86. It no longer needs to
> > > set num_leaves, and it never had to set num_levels, which was unnecessary
> > > on x86.
> > >
> > > Replace it with "return 0" simply to override the weak function, which
> > > would return an error.
> > >
> > > Reviewed-by: Len Brown <len.brown@xxxxxxxxx>
> > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@xxxxxxxxxxxxxxx>
> >
> > Reviewed-by: Andreas Herrmann <aherrmann@xxxxxxx>
> > Tested-by: Andreas Herrmann <aherrmann@xxxxxxx>
> >
> > Test was done with a system equipped with AMD Phenom II X6 1055T and
> > test kernels based on v6.11-rc5-176-g20371ba12063.
>
> FYI, the test consisted of booting the mainline kernel w/o and w/ your
> patches, checking for potential new errors/warnings in kernel log and
> checking for changes or incosistencies in information of cache
> characteristics as reported in sysfs, and by some tools (lscpu,
> lstopo, x86info) -- e.g. x86info does not use sysfs to gather cache
> information for CPUs.
Thank you very much for you review and testing!
I will post a new version with the feedback from Nikolay and Sudeep and
your tags.
BR,
Ricardo