Re: [PATCH] pwm: Use of_property_read_bool()

From: Uwe Kleine-König
Date: Wed Sep 04 2024 - 03:29:54 EST


On Tue, Sep 03, 2024 at 02:19:01PM -0500, Rob Herring wrote:
> On Thu, Aug 1, 2024 at 3:41 AM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxx> wrote:
> >
> > Hello,
> >
> > On Wed, Jul 31, 2024 at 01:13:03PM -0600, Rob Herring (Arm) wrote:
> > > Use of_property_read_bool() to read boolean properties rather than
> > > of_get_property(). This is part of a larger effort to remove callers
> > > of of_get_property() and similar functions. of_get_property() leaks
> > > the DT property data pointer which is a problem for dynamically
> > > allocated nodes which may be freed.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > > ---
> > > drivers/pwm/pwm-omap-dmtimer.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Looks good to me. Unless you object I'd apply with adding
> > "omap-dmtimer: " to the short log.
>
> No objection and sorry I missed that.

No problem for me, applied with the mentioned change to the short log to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature