Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp: Add Microsoft Surface Pro 9 5G

[Johan Hovold]

On Wed, Sep 04, 2024 at 09:46:09AM +0200, Krzysztof Kozlowski wrote:
> On 04/09/2024 00:42, Jérôme de Bretagne wrote:
> > Add an initial devicetree for the Microsoft Surface Pro 9 5G, based
> > on SC8280XP.

> Rest looks good, except ordering of nodes/overrides/phandles. They
> should go alphabetically, AFAIR, so your &tlmm is placed in wrong spot.

For the other sc8280xp machines (and I believe at least some other
SoCs), we placed the pinctrl section, which tends to be quite long, last
on purpose with a separating header (e.g. so that it is easy to find):

	/* PINCTRL */

	&pmr735a_gpios {
	...

	&tlmm {


Looks like the header comment is missing here if you want to follow that
style, though.

Johan