Re: [PATCH V2 2/2] firmware: arm_scmi: Skip adding bad duplicates

From: Johan Hovold
Date: Wed Sep 04 2024 - 04:05:38 EST


On Wed, Sep 04, 2024 at 09:09:56AM +0200, Johan Hovold wrote:
> On Wed, Sep 04, 2024 at 08:43:24AM +0530, Sibi Sankar wrote:
> > Ensure that the bad duplicates reported by the platform firmware doesn't
> > get added to the opp-tables.

> But with this patch applied, instead of the above warnings I now get two
> *errors* at boot:
>
> [ 8.952173] cpu cpu4: EM: non-increasing freq: 0
> [ 8.979460] cpu cpu8: EM: non-increasing freq: 0
>
> Can you do something about that as well? At least make sure to highlight
> this in the commit message as this is information that is needed to be
> able to evaluate the patch.

I tried running with just this patch (i.e. without patch 1/2), but then
cpufreq fails already during boot with eight of these errors:

[ 9.258577] cpufreq: cpufreq_online: ->get() failed
...
[ 9.405603] cpufreq: cpufreq_online: ->get() failed

and seven of these messages:

[ 12.322987] energy_model: Accessing cpu4 policy failed
...
[ 18.462780] energy_model: Accessing cpu4 policy failed

Johan