Re: [PATCH v3 09/12] ext4: drop unused ext4_es_store_status()

From: Jan Kara
Date: Wed Sep 04 2024 - 06:26:22 EST


On Tue 13-08-24 20:34:49, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@xxxxxxxxxx>
>
> The helper ext4_es_store_status() is unused now, just drop it.
>
> Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx>

Yes. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> fs/ext4/extents_status.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ext4/extents_status.h b/fs/ext4/extents_status.h
> index 47b3b55a852c..3ca40f018994 100644
> --- a/fs/ext4/extents_status.h
> +++ b/fs/ext4/extents_status.h
> @@ -224,13 +224,6 @@ static inline void ext4_es_store_pblock(struct extent_status *es,
> es->es_pblk = block;
> }
>
> -static inline void ext4_es_store_status(struct extent_status *es,
> - unsigned int status)
> -{
> - es->es_pblk = (((ext4_fsblk_t)status << ES_SHIFT) & ES_MASK) |
> - (es->es_pblk & ~ES_MASK);
> -}
> -
> static inline void ext4_es_store_pblock_status(struct extent_status *es,
> ext4_fsblk_t pb,
> unsigned int status)
> --
> 2.39.2
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR