Re: [PATCH net-next v3] net: enetc: Replace ifdef with IS_ENABLED

[Vladimir Oltean]

On Wed, Sep 04, 2024 at 12:11:31PM +0100, Vadim Fedorenko wrote:
> On 04/09/2024 11:51, Martyn Welch wrote:
> > The enetc driver uses ifdefs when checking whether
> > CONFIG_FSL_ENETC_PTP_CLOCK is enabled in a number of places. This works
> > if the driver is compiled in but fails if the driver is available as a
> > kernel module. Replace the instances of ifdef with use of the IS_ENABLED
> > macro, that will evaluate as true when this feature is built as a kernel
> > module and follows the kernel's coding style.
> > 
> > Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> > Reviewed-by: Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>
> 
> If there will be v4, please, put yours SoB as the last tag after all
> other tags.
> 
> Thanks,
> Vadim

What's the deal with this? If I give my review tag now, and the patch
will subsequently be applied, my Reviewed-by: tag will also appear after
his SoB.