Re: [PATCH net-next v2 0/7] microchip_t1s: Update on Microchip 10BASE-T1S PHY driver

[Parthiban.Veerasooran]

Hi Horatiu,

On 03/09/24 11:54 am, Horatiu Vultur wrote:
> The 09/02/2024 20:04, Parthiban Veerasooran wrote:
> 
> Hi Parthiban,
> 
>> This patch series contain the below updates,
>>
>> v1:
> 
> You usually use v1, v2, v3 to say what is the difference between series.
> But in your case you already had v1 already in first patch series which
> it is strange to be used. I think you wanted to just describe the
> features of this patch series.
> So, my suggestion is to drop v1 because those are the features not
> changes between version, and put ':' instead of ',' after updates.
Ah yes, will correct them in the next version.
> 
> Also almost all your patches in this series start with 'This patch',
> please change this to imperative mode:
> https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html
OK. Will correct them in the next version.

Best regards,
Parthiban V
> 
>> - Restructured lan865x_write_cfg_params() and lan865x_read_cfg_params()
>>    functions arguments to more generic.
>> - Updated new/improved initial settings of LAN865X Rev.B0 from latest
>>    AN1760.
>> - Added support for LAN865X Rev.B1 from latest AN1760.
>> - Moved LAN867X reset handling to a new function for flexibility.
>> - Added support for LAN867X Rev.C1/C2 from latest AN1699.
>> - Disabled/enabled collision detection based on PLCA setting.
>>
>> v2:
>> - Fixed indexing issue in the configuration parameter setup.
>>
>> Parthiban Veerasooran (7):
>>    net: phy: microchip_t1s: restructure cfg read/write functions
>>      arguments
>>    net: phy: microchip_t1s: update new initial settings for LAN865X
>>      Rev.B0
>>    net: phy: microchip_t1s: add support for Microchip's LAN865X Rev.B1
>>    net: phy: microchip_t1s: move LAN867X reset handling to a new function
>>    net: phy: microchip_t1s: add support for Microchip's LAN867X Rev.C1
>>    net: phy: microchip_t1s: add support for Microchip's LAN867X Rev.C2
>>    net: phy: microchip_t1s: configure collision detection based on PLCA
>>      mode
>>
>>   drivers/net/phy/Kconfig         |   4 +-
>>   drivers/net/phy/microchip_t1s.c | 299 +++++++++++++++++++++++++-------
>>   2 files changed, 239 insertions(+), 64 deletions(-)
>>
>>
>> base-commit: 221f9cce949ac8042f65b71ed1fde13b99073256
>> -- 
>> 2.34.1
>>
>