Re: [PATCH v5 2/5] phy: stm32: Add support for STM32MP25 COMBOPHY.
From: kernel test robot
Date: Wed Sep 04 2024 - 07:51:22 EST
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on atorgue-stm32/stm32-next]
[also build test WARNING on robh/for-next linus/master v6.11-rc6 next-20240904]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-Bruel/dt-bindings-phy-Add-STM32MP25-COMBOPHY-bindings/20240903-201737
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link: https://lore.kernel.org/r/20240903121303.2953150-3-christian.bruel%40foss.st.com
patch subject: [PATCH v5 2/5] phy: stm32: Add support for STM32MP25 COMBOPHY.
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240904/202409041913.v0xzfcJ2-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240904/202409041913.v0xzfcJ2-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409041913.v0xzfcJ2-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/phy/st/phy-stm32-combophy.c:524:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
524 | return ret;
| ^~~
drivers/phy/st/phy-stm32-combophy.c:509:9: note: initialize the variable 'ret' to silence this warning
509 | int ret, irq;
| ^
| = 0
1 warning generated.
vim +/ret +524 drivers/phy/st/phy-stm32-combophy.c
503
504 static int stm32_combophy_probe(struct platform_device *pdev)
505 {
506 struct stm32_combophy *combophy;
507 struct device *dev = &pdev->dev;
508 struct phy_provider *phy_provider;
509 int ret, irq;
510
511 combophy = devm_kzalloc(dev, sizeof(*combophy), GFP_KERNEL);
512 if (!combophy)
513 return -ENOMEM;
514
515 combophy->dev = dev;
516
517 dev_set_drvdata(dev, combophy);
518
519 combophy->base = devm_platform_ioremap_resource(pdev, 0);
520 if (IS_ERR(combophy->base))
521 return PTR_ERR(combophy->base);
522
523 if (stm32_combophy_get_clocks(combophy))
> 524 return ret;
525
526 combophy->phy_reset = devm_reset_control_get(dev, "phy");
527 if (IS_ERR(combophy->phy_reset))
528 return dev_err_probe(dev, PTR_ERR(combophy->phy_reset),
529 "Failed to get PHY reset\n");
530
531 combophy->regmap = syscon_regmap_lookup_by_compatible("st,stm32mp25-syscfg");
532 if (IS_ERR(combophy->regmap))
533 return dev_err_probe(dev, PTR_ERR(combophy->regmap),
534 "No syscfg specified\n");
535
536 combophy->phy = devm_phy_create(dev, NULL, &stm32_combophy_phy_data);
537 if (IS_ERR(combophy->phy))
538 return dev_err_probe(dev, PTR_ERR(combophy->phy),
539 "failed to create PCIe/USB3 ComboPHY\n");
540
541 if (device_property_read_bool(dev, "wakeup-source")) {
542 irq = platform_get_irq(pdev, 0);
543 if (irq < 0)
544 return dev_err_probe(dev, irq, "failed to get IRQ\n");
545 combophy->irq_wakeup = irq;
546
547 ret = devm_request_threaded_irq(dev, combophy->irq_wakeup, NULL,
548 stm32_combophy_irq_wakeup_handler, IRQF_ONESHOT,
549 NULL, NULL);
550 if (ret)
551 return dev_err_probe(dev, ret, "unable to request wake IRQ %d\n",
552 combophy->irq_wakeup);
553 }
554
555 ret = devm_pm_runtime_enable(dev);
556 if (ret)
557 return dev_err_probe(dev, ret, "Failed to enable pm runtime\n");
558
559 phy_set_drvdata(combophy->phy, combophy);
560
561 phy_provider = devm_of_phy_provider_register(dev, stm32_combophy_xlate);
562
563 return PTR_ERR_OR_ZERO(phy_provider);
564 }
565
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki