Re: [PATCH v2 1/1] media: i2c: max96717: add test pattern ctrl

[Sakari Ailus]

Hi Tommaso,

On Wed, Sep 04, 2024 at 03:01:36PM +0200, Tommaso Merciai wrote:
> On Wed, Sep 04, 2024 at 02:53:55PM +0200, Tommaso Merciai wrote:
> > Hi Sakari,
> > Sorry for delay and thanks for reviewing this.

No problem.

> > 
> > On Wed, Aug 28, 2024 at 06:44:19AM +0000, Sakari Ailus wrote:
> > > >  	priv->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_STREAMS;
> > > 
> > > With controls, you should add the HAS_EVENTS flag.
> > > 
> > > I'll take this one as we're in rc5 already, please address these in a
> > > separate patch.
> > 
> > 
> > Will send a patch for this. 
> > I think we should fix that also into max96717 driver or I'm wrong?
> 
> max96714 sorry.

Yes, please.

-- 
Kind regards,

Sakari Ailus