Re: [PATCH] mailbox: Use of_property_match_string() instead of open-coding
From: Rob Herring
Date: Wed Sep 04 2024 - 09:21:39 EST
On Tue, Sep 3, 2024 at 4:05 PM Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:
>
> On Tue, Sep 3, 2024 at 2:18 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> >
> > On Wed, Jul 31, 2024 at 3:16 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
> > >
> > > Use of_property_match_string() instead of open-coding the search. With
> > > this, of_get_property() can be removed as there is no need to check for
> > > "mbox-names" presence first.
> > >
> > > This is part of a larger effort to remove callers of of_get_property()
> > > and similar functions. of_get_property() leaks the DT property data
> > > pointer which is a problem for dynamically allocated nodes which may
> > > be freed.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > > ---
> > > drivers/mailbox/mailbox.c | 22 ++++++----------------
> > > 1 file changed, 6 insertions(+), 16 deletions(-)
> >
> > Ping!
> >
> Acked-by: Jassi Brar <jassisinghbrar@xxxxxxxxx>
Don't need an ack, are you going to apply?
Rob