Re: [PATCH 11/15] regulator: core: Use fsleep() to get best sleep mechanism

From: Mark Brown
Date: Wed Sep 04 2024 - 09:28:54 EST


On Wed, Sep 04, 2024 at 03:05:01PM +0200, Anna-Maria Behnsen wrote:
> _regulator_delay_helper() implements the recommondation of the outdated
> documentation which sleep mechanism should be used. There is already a
> function in place which does everything and also maps to reality called
> fsleep().

> - * Delay for the requested amount of time as per the guidelines in:
> + * For details please refere to fsleep() function description.

> -static void _regulator_delay_helper(unsigned int delay)
> +static inline void _regulator_delay_helper(unsigned int delay)

Gien that this just becomes a trivial wrapper for fsleep() why not just
replace all the calls with fsleep() and remove the function entirely?

Attachment: signature.asc
Description: PGP signature