Re: [PATCH 0/4] Microsoft Surface Pro 9 5G support

[Rob Herring (Arm)]

On Wed, 04 Sep 2024 00:42:48 +0200, Jérôme de Bretagne wrote:
> This series brings support for the SC8280XP-based Microsoft Surface
> Pro 9 5G.
> 
> Jérôme de Bretagne (4):
>   dt-bindings: arm: qcom: Document Microsoft Surface Pro 9 5G
>   firmware: qcom: scm: Allow QSEECOM on Microsoft Surface Pro 9 5G
>   arm64: dts: qcom: sc8280xp: Add uart18
>   arm64: dts: qcom: sc8280xp: Add Microsoft Surface Pro 9 5G
> 
>  .../devicetree/bindings/arm/qcom.yaml         |    1 +
>  arch/arm64/boot/dts/qcom/Makefile             |    1 +
>  .../sc8280xp-microsoft-surface-pro-9-5G.dts   | 1099 +++++++++++++++++
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi        |   14 +
>  drivers/firmware/qcom/qcom_scm.c              |    1 +
>  5 files changed, 1116 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sc8280xp-microsoft-surface-pro-9-5G.dts
> 
> --
> 2.45.2
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/sc8280xp-microsoft-surface-pro-9-5G.dtb' for 20240903224252.6207-1-jerome.debretagne@xxxxxxxxx:

arch/arm64/boot/dts/qcom/sc8280xp-microsoft-surface-pro-9-5G.dtb: geniqup@8c0000: serial@888000: Unevaluated properties are not allowed ('surface-aggregator' was unexpected)
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-microsoft-surface-pro-9-5G.dtb: serial@888000: Unevaluated properties are not allowed ('surface-aggregator' was unexpected)
	from schema $id: http://devicetree.org/schemas/serial/qcom,serial-geni-qcom.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-microsoft-surface-pro-9-5G.dtb: /soc@0/geniqup@8c0000/serial@888000/surface-aggregator: failed to match any schema with compatible: ['surface,aggregator']
arch/arm64/boot/dts/qcom/sc8280xp-microsoft-surface-pro-9-5G.dtb: pinctrl@f100000: ssam-state: 'oneOf' conditional failed, one must be fixed:
	'function' is a required property
	Unevaluated properties are not allowed ('wake-int' was unexpected)
	'pins' is a required property
	'wake-int' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sc8280xp-tlmm.yaml#
arch/arm64/boot/dts/qcom/sc8280xp-microsoft-surface-pro-9-5G.dtb: pinctrl@f100000: uart18-state: 'oneOf' conditional failed, one must be fixed:
	'function' is a required property
	Unevaluated properties are not allowed ('cts', 'rts-tx', 'rx' were unexpected)
	'pins' is a required property
	'cts', 'rts-tx', 'rx' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sc8280xp-tlmm.yaml#