Re: [PATCH V5 5/5] phy: freescale: fsl-samsung-hdmi: Remove unnecessary LUT entries

From: Adam Ford
Date: Wed Sep 04 2024 - 10:00:31 EST


On Wed, Sep 4, 2024 at 8:44 AM Frieder Schrempf
<frieder.schrempf@xxxxxxxxxx> wrote:
>
> On 04.09.24 4:32 AM, Adam Ford wrote:
> > The lookup table contains entries which use the integer divider
> > instead of just the fractional divider. Since the set and round
>
> ^ unneeded whitespace
>
> > functions check both the integer divider values and the LUT values,
> > it's no longer necessary to keep the integer divder values in the,
>
> ^ divider ^ table?
> > as they are able to by dynamically calcuated.
>
> ^ can be calculated dynamically.
>

Wow, I must have been really tired when I wrote this. I promise that
I wasn't drinking. :-)

I will fix and proof-read my comments in the V6. :-)


adam
> >
> > Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
>
> With commit message fixed:
>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> Tested-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>