Re: [PATCH 1/1] dt-bindings: mmc: Add support for rk3576 eMMC

[Krzysztof Kozlowski]

On 04/09/2024 16:20, Detlev Casanova wrote:
>>>>> +      properties:
>>>>> +        power-domains:
>>>>> +          minItems: 1
>>>>
>>>> Why minItems? This does not look right. I don't get what you are trying
>>>> to say here.
>>>
>>> I'm saying that for the rockchip,rk3576-dwcmshc compatible, 1 power-domain
>>> node has to be set.
>>
>> The top-level property already says this. You need to disallow it for
>> other variants (:false).
> 
> Ok, something like this:
> 
> allOf:
>   - if:
>       properties:
>         compatible:
>           contains:
>             const: rockchip,rk3576-dwcmshc
> 
>     then:
>       required:
>         - power-domains
> 
>     else:
>       properties:
>         power-domains: false

Yes, if they are required. Otherwise use "if: not:" and just disallow them.

Best regards,
Krzysztof