Re: [PATCH v3 2/2] iio: dac: support the ad8460 Waveform DAC

From: kernel test robot
Date: Wed Sep 04 2024 - 11:52:02 EST


Hi Mariel,

kernel test robot noticed the following build errors:

[auto build test ERROR on c4b43d8336e52dce6d124e428aa3b71703e62647]

url: https://github.com/intel-lab-lkp/linux/commits/Mariel-Tinaco/dt-bindings-iio-dac-add-docs-for-ad8460/20240904-103413
base: c4b43d8336e52dce6d124e428aa3b71703e62647
patch link: https://lore.kernel.org/r/20240904023040.23352-3-Mariel.Tinaco%40analog.com
patch subject: [PATCH v3 2/2] iio: dac: support the ad8460 Waveform DAC
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240904/202409042318.7nwvZc3c-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240904/202409042318.7nwvZc3c-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409042318.7nwvZc3c-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/iio/dac/ad8460.c: In function 'ad8460_get_hvdac_word':
>> drivers/iio/dac/ad8460.c:165:16: error: implicit declaration of function 'get_unaligned_le16' [-Wimplicit-function-declaration]
165 | *val = get_unaligned_le16(state->spi_tx_buf);
| ^~~~~~~~~~~~~~~~~~
drivers/iio/dac/ad8460.c: In function 'ad8460_set_hvdac_word':
>> drivers/iio/dac/ad8460.c:172:9: error: implicit declaration of function 'put_unaligned_le16' [-Wimplicit-function-declaration]
172 | put_unaligned_le16(FIELD_PREP(AD8460_DATA_BYTE_FULL_MSK, val),
| ^~~~~~~~~~~~~~~~~~


vim +/get_unaligned_le16 +165 drivers/iio/dac/ad8460.c

155
156 static int ad8460_get_hvdac_word(struct ad8460_state *state, int index, int *val)
157 {
158 int ret;
159
160 ret = regmap_bulk_read(state->regmap, AD8460_HVDAC_DATA_WORD_LOW(index),
161 &state->spi_tx_buf, AD8460_DATA_BYTE_WORD_LENGTH);
162 if (ret)
163 return ret;
164
> 165 *val = get_unaligned_le16(state->spi_tx_buf);
166
167 return ret;
168 }
169
170 static int ad8460_set_hvdac_word(struct ad8460_state *state, int index, int val)
171 {
> 172 put_unaligned_le16(FIELD_PREP(AD8460_DATA_BYTE_FULL_MSK, val),
173 &state->spi_tx_buf);
174
175 return regmap_bulk_write(state->regmap, AD8460_HVDAC_DATA_WORD_LOW(index),
176 state->spi_tx_buf, AD8460_DATA_BYTE_WORD_LENGTH);
177 }
178

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki