Re: [PATCH 5.15 000/215] 5.15.166-rc1 review

[Greg KH]

On Wed, Sep 04, 2024 at 01:00:26PM -0700, Richard Narron wrote:
> On Wed, 4 Sep 2024, Greg KH wrote:
> 
> > On Wed, Sep 04, 2024 at 05:48:09AM -0700, Richard Narron wrote:
> > > On Wed, 4 Sep 2024, Greg KH wrote:
> > >
> > > > On Mon, Sep 02, 2024 at 03:39:49PM -0700, Richard Narron wrote:
> > > > > I get an "out of memory" error when building Linux kernels 5.15.164,
> > > > > 5.15.165 and 5.15.166-rc1:
> > > > > ...
> > > > > cc1: out of memory allocating 180705472 bytes after a total of 283914240
> > > > > bytes
> > > > > ...
> > > > > make[4]: *** [scripts/Makefile.build:289:
> > > > > drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.o]
> > > > > Error 1
> > > > > ...
> > > > >
> > > > > I found a work around for this problem.
> > > > >
> > > > > Remove the six minmax patches introduced with kernel 5.15.164:
> > > > >
> > > > > minmax: allow comparisons of 'int' against 'unsigned char/short'
> > > > > minmax: allow min()/max()/clamp() if the arguments have the same
> > > > > minmax: clamp more efficiently by avoiding extra comparison
> > > > > minmax: fix header inclusions
> > > > > minmax: relax check to allow comparison between unsigned arguments
> > > > > minmax: sanity check constant bounds when clamping
> > > > >
> > > > > Can these 6 patches be removed or fixed?
> > > >
> > > > It's a bit late, as we rely on them for other changes.
> > > >
> > > > Perhaps just fixes for the files that you are seeing build crashes on?
> > > > I know a bunch of them went into Linus's tree for this issue, but we
> > > > didn't backport them as I didn't know what was, and was not, needed.  If
> > > > you can pinpoint the files that cause crashes, I can dig them up.
> > > >
> > >
> > > The first one to fail on 5.15.164 was:
> > > drivers/media/pci/solo6x10/solo6x10-core.o
> > >
> > > So I found and applied this patch to 5.15.164:
> > > [PATCH] media: solo6x10: replace max(a, min(b, c)) by clamp(b, a, c)
> >
> > What is the git commit id of that change?  I can't seem to find it.
> 
> 31e97d7c9ae3
> 
> >From Salvatore Bonaccorso to stable on 22 Aug 2024 19:19:27 +0200
> 
>   Subject: Please apply commit 31e97d7c9ae3 ("media: solo6x10: replace
> max(a, min(b, c)) by clamp(b, a, c)") to 6.1.y
> ...
>   "Note I suspect it is required as well for 5.15.164 (as the commits
> were backported there as well and 31e97d7c9ae3 now missing there)"

That is already in 5.15.166, can you verify it is resolved for you
there?

> > > Then the next to fail on 5.15.164 was:
> > > drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.o
> >
> > What .c file is this happening for?
> 
> Probably this one:
> drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.c

Did you see this also building this file in 6.10 or anything newer than
5.15.y?

thanks,

greg k-h