RE: [PATCH v2 2/3] spi: fspi: add support for imx8ulp
From: Bough Chen
Date: Wed Sep 04 2024 - 21:49:19 EST
> -----Original Message-----
> From: Fabio Estevam <festevam@xxxxxxxxx>
> Sent: 2024年9月5日 9:38
> To: Bough Chen <haibo.chen@xxxxxxx>
> Cc: Han Xu <han.xu@xxxxxxx>; yogeshgaur.83@xxxxxxxxx;
> broonie@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; singh.kuldeep87k@xxxxxxxxx; hs@xxxxxxx;
> linux-spi@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/3] spi: fspi: add support for imx8ulp
>
> Hi Haibo,
>
> On Wed, Sep 4, 2024 at 10:26 PM <haibo.chen@xxxxxxx> wrote:
>
> > @@ -373,6 +367,16 @@ static struct nxp_fspi_devtype_data imx8dxl_data =
> {
> > .txfifo = SZ_1K, /* (128 * 64 bits) */
> > .ahb_buf_size = SZ_2K, /* (256 * 64 bits) */
> > .quirks = FSPI_QUIRK_USE_IP_ONLY,
> > + .lut_num = 32,
> > + .little_endian = true, /* little-endian */
>
> The addition of little_endian to imx8dl should be a separate patch.
Hi Fabio,
I only add the .lut_num here, do not touch .lettle_endian here, and I add another 8ulp in the follow line, but format patch show in this way. Anything I can do to adjust how to format patch?
Best Regards
Haibo Chen
>
> The comment is pointless too.