Re: [PATCH v5 1/2] dt-bindings: iio: imu: smi240: add Bosch smi240

From: Krzysztof Kozlowski
Date: Thu Sep 05 2024 - 02:33:01 EST


On Wed, Sep 04, 2024 at 04:05:05PM +0200, Jianping.Shen@xxxxxxxxxxxx wrote:
> From: Shen Jianping <Jianping.Shen@xxxxxxxxxxxx>
>
> Add devicetree binding for Bosch imu smi240.
> The smi240 is a combined three axis angular rate and
> three axis acceleration sensor module.
>
> * The smi240 requires VDD and VDDIO
> * Provides only spi interface.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Shen Jianping <Jianping.Shen@xxxxxxxxxxxx>
> ---
> .../bindings/iio/imu/bosch,smi240.yaml | 52 +++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
>

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

Best regards,
Krzysztof