Re: [PATCH v4 2/7] dt-bindings: PCI: ti,am65: Extend for use with PVU
From: Krzysztof Kozlowski
Date: Thu Sep 05 2024 - 02:58:04 EST
On 04/09/2024 12:00, Jan Kiszka wrote:
> +
> + reg-names:
> + minItems: 4
> + items:
> + - const: app
> + - const: dbics
> + - const: config
> + - const: atu
> + - const: vmap_lp
> + - const: vmap_hp
> +
> + memory-region:
This also did not improve. You did not address any feedback from v3.
Missed feedback:
This *must* be defined in top-level.
I still think this must have some sort of maxItems. I accept your
explanation that you could have multiple memory pools, but I don't think
2147000 pools is possible. Make it 4, 8 or 32.
> + minItems: 1
> + description: |
> + phandle to one or more restricted DMA pools to be used for all devices
> + behind this controller. The regions should be defined according to
> + reserved-memory/shared-dma-pool.yaml.
> + items:
> + maxItems: 1
Best regards,
Krzysztof