Re: [PATCH v4 04/14] xfs: make EOF allocation simpler

[John Garry]

On 04/09/2024 19:25, Ritesh Harjani (IBM) wrote:
> > diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
> > index 2fa29d2f004e..c5d220d51757 100644
> > --- a/fs/xfs/libxfs/xfs_ialloc.c
> > +++ b/fs/xfs/libxfs/xfs_ialloc.c
> > @@ -780,7 +780,7 @@ xfs_ialloc_ag_alloc(
> >   		 * the exact agbno requirement and increase the alignment
> >   		 * instead. It is critical that the total size of the request
> >   		 * (len + alignment + slop) does not increase from this point
> > -		 * on, so reset minalignslop to ensure it is not included in
> > +		 * on, so reset alignslop to ensure it is not included in
> >   		 * subsequent requests.
> >   		 */
> >   		args.alignslop = 0;
> minor comment: Looks like this diff got leftover from previous patch
> where we cleanup minalignslop/alignslop.

Right, that comment modification belongs in the previous patch - I will 
relocate.

Thanks,
John