Re: [moderation] [f2fs?] WARNING: still has locks held in f2fs_ioc_start_atomic_write

[Dmitry Vyukov]

On Thu, 5 Sept 2024 at 10:16, Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
>
> Hi Chao,
>
> The commands should not have space at the beginning of the line, and
> also preferably sent not in HTML (I did n't check what is in the
> plain/text section of your email).
> You can always check if syzbot has received your command at the bug page:
> https://syzkaller.appspot.com/bug?extid=a2197ed0ab131bbc9d02
>
> But thanks for marking it as fixed:
>
>

Also one needs to keep syzbot email in CC, otherwise it does not know
the bug you refer to.
Let's try again:

#syz fix: f2fs: atomic: fix to forbid dio in atomic_file

> On Thu, 5 Sept 2024 at 08:49, Chao Yu <yuchaochina@xxxxxxxxx> wrote:
> >
> >  #syz fix: f2fs: atomic: fix to forbid dio in atomic_file
> >
> > 在2024年8月16日星期五 UTC+8 17:16:28<syzbot> 写道：
> >>
> >> Hello,
> >>
> >> syzbot found the following issue on:
> >>
> >> HEAD commit: 9e6869691724 Add linux-next specific files for 20240812
> >> git tree: linux-next
> >> console output: https://syzkaller.appspot.com/x/log.txt?x=14d27ae5980000
> >> kernel config: https://syzkaller.appspot.com/x/.config?x=61ba6f3b22ee5467
> >> dashboard link: https://syzkaller.appspot.com/bug?extid=a2197ed0ab131bbc9d02
> >> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> >> CC: [ch...@xxxxxxxxxx jae...@xxxxxxxxxx linux-f2...@xxxxxxxxxxxxxxxxxxxxx linux-...@xxxxxxxxxxxxxxx]
> >>
> >> Unfortunately, I don't have any reproducer for this issue yet.
> >>
> >> Downloadable assets:
> >> disk image: https://storage.googleapis.com/syzbot-assets/f1b086192f50/disk-9e686969.raw.xz
> >> vmlinux: https://storage.googleapis.com/syzbot-assets/b457920fb52e/vmlinux-9e686969.xz
> >> kernel image: https://storage.googleapis.com/syzbot-assets/e63ba9cce98a/bzImage-9e686969.xz
> >>
> >> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> >> Reported-by: syzbot+a2197e...@xxxxxxxxxxxxxxxxxxxxxxxxx
> >>
> >> ====================================
> >> WARNING: syz.0.454/7910 still has locks held!
> >> 6.11.0-rc3-next-20240812-syzkaller #0 Not tainted
> >> ------------------------------------
> >> 1 lock held by syz.0.454/7910:
> >> #0: ffff888011f98f50 (&fi->i_gc_rwsem[READ]){+.+.}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2196 [inline]
> >> #0: ffff888011f98f50 (&fi->i_gc_rwsem[READ]){+.+.}-{3:3}, at: f2fs_ioc_start_atomic_write+0x2ed/0xac0 fs/f2fs/file.c:2163
> >>
> >> stack backtrace:
> >> CPU: 0 UID: 0 PID: 7910 Comm: syz.0.454 Not tainted 6.11.0-rc3-next-20240812-syzkaller #0
> >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024
> >> Call Trace:
> >> <TASK>
> >> __dump_stack lib/dump_stack.c:94 [inline]
> >> dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
> >> do_exit+0x1b67/0x28e0 kernel/exit.c:969
> >> do_group_exit+0x207/0x2c0 kernel/exit.c:1088
> >> get_signal+0x176f/0x1810 kernel/signal.c:2936
> >> arch_do_signal_or_restart+0x96/0x830 arch/x86/kernel/signal.c:337
> >> exit_to_user_mode_loop kernel/entry/common.c:111 [inline]
> >> exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline]
> >> __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline]
> >> syscall_exit_to_user_mode+0xc9/0x370 kernel/entry/common.c:218
> >> do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89
> >> entry_SYSCALL_64_after_hwframe+0x77/0x7f
> >> RIP: 0033:0x7f7ba21779f9
> >> Code: Unable to access opcode bytes at 0x7f7ba21779cf.
> >> RSP: 002b:00007f7ba2fa4038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> >> RAX: fffffffffffffffb RBX: 00007f7ba2306208 RCX: 00007f7ba21779f9
> >> RDX: 0000000000000000 RSI: 000000000000f501 RDI: 0000000000000005
> >> RBP: 00007f7ba21e58ee R08: 0000000000000000 R09: 0000000000000000
> >> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
> >> R13: 0000000000000001 R14: 00007f7ba2306208 R15: 00007ffc9069b428
> >> </TASK>
> >>
> >>
> >> ---
> >> This report is generated by a bot. It may contain errors.
> >> See https://goo.gl/tpsmEJ for more information about syzbot.
> >> syzbot engineers can be reached at syzk...@xxxxxxxxxxxxxxxx.
> >>
> >> syzbot will keep track of this issue. See:
> >> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> >>
> >> If the report is already addressed, let syzbot know by replying with:
> >> #syz fix: exact-commit-title
> >>
> >> If you want to overwrite report's subsystems, reply with:
> >> #syz set subsystems: new-subsystem
> >> (See the list of subsystem names on the web dashboard)
> >>
> >> If the report is a duplicate of another one, reply with:
> >> #syz dup: exact-subject-of-another-report
> >>
> >> If you want to undo deduplication, reply with:
> >> #syz undup
> >
> > --
> > You received this message because you are subscribed to the Google Groups "syzkaller-upstream-moderation" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-upstream-moderation+unsubscribe@xxxxxxxxxxxxxxxx.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-upstream-moderation/e8ce9858-87ab-4f0b-85a8-8817ec376986n%40googlegroups.com.