Re: [PATCH] amba: make amba_bustype constant

From: Kunwu Chan
Date: Thu Sep 05 2024 - 04:51:53 EST


Thanks for the reply.
On 2024/9/4 21:58, Russell King (Oracle) wrote:
On Thu, Aug 29, 2024 at 09:31:29AM +0800, Kunwu Chan wrote:
Thanks for the reply.
On 2024/8/28 21:17, Andy Shevchenko wrote:
On Wed, Aug 28, 2024 at 10:51:54AM +0800, Kunwu Chan wrote:
On 2024/8/27 21:37, Andy Shevchenko wrote:
On Tue, Aug 27, 2024 at 03:45:31PM +0800, Kunwu Chan wrote:
On 2024/8/26 18:40, Andy Shevchenko wrote:
On Mon, Aug 26, 2024 at 06:08:11PM +0800, Kunwu Chan wrote:
...

Make it patch series:
1) patch that introduces exported function called dev_is_amba() (1 patch)
Done.
2) convert user-by-user (N patches)
I've no idea about how to modify, such as in iommu.c:
Oh, crap. Yes, this need more thinking.
Anyway, Russell is okay with your initial patch, the rest can be done
separately. For now probably we can leave it exported for this only case.

Anyway, thanks for the suggestion, i'll   introduce the dev_is_amba function

and  add the Suggested tag for you.

If you have a better idea and need me to do it, you can always contact me.
General policy is not to add stuff that doesn't have any users. From
what I can see from briefly reading this discussion, and looking at
the patches submitted to me, the dev_is_amba() patch adds a helper,
but as yet there are no users - and not even any patches on a mailing
list to make use of this helper. Therefore, I won't be applying that
patch.

Actually, here is a user in [1], i'am ready to use it  in [2].

#ifdef CONFIG_ARM_AMBA
else if (dev->bus == &amba_bustype)

[1] https://elixir.bootlin.com/linux/v6.10.8/source/drivers/of/platform.c#L631

[2] https://lore.kernel.org/all/20240828150826.GA3803566-robh@xxxxxxxxxx/

Good idea, but it needs users...

Please note that I likely won't be reading further discussion (see
my signature below, and I'm having the same op on the other eye -
which is the only eye suitable for screen work at the moment -
this Friday.)

Sure, i've send it to the armlinux.org.uk as:

https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9415/1

https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9416/1


Good health.

--
Thanks,
Kunwu.Chan