Re: [PATCHv2 net-next 6/8] net: ibm: emac: use netdev's phydev directly
From: Paolo Abeni
Date: Thu Sep 05 2024 - 06:12:06 EST
Hi,
On 9/3/24 21:42, Rosen Penev wrote:
@@ -2622,26 +2618,28 @@ static int emac_dt_mdio_probe(struct emac_instance *dev)
static int emac_dt_phy_connect(struct emac_instance *dev,
struct device_node *phy_handle)
{
+ struct phy_device *phy_dev = dev->ndev->phydev;
The above assignment looks confusing/not needed, as 'phy_dev' will be
initialized a few line later and not used in between.
Cheers,
Paolo