Re: [PATCH v15 00/10] Add support for Core Power Reduction v3, v4 and Hardened

[Ulf Hansson]

On Mon, 8 Jul 2024 at 14:22, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
> Changes in v15:
> - Rebase (incl. genpd -> pmdomain rename)
> - Change the maintainer to myself
> - Drop tested-bys
> - Rewrite some commit messages
> - Temporarily drop CPR3 support (easy to add back, adds complexity and
>   requires more testing.. unnecessarily slowing down this already 3+
>   years old series)
> - Boring style changes (fix indentation etc.)
> - Sprinkle a lot of dev_err_probe to make failures meaningful at all
> - Fix some misleading comments
> - Rename the "cprh" power domain to "perf"
> - Allow and mark the CPR OPPs as shared
> - Include fixes equivalent to Varadarajan's (over at:
>   https://github.com/quic-varada/cpr/commit/f025f13a2e64b13c8e7866bedc3bfa73f2aaf162)

[...]

> AngeloGioacchino Del Regno (6):
>       dt-bindings: soc: qcom: cpr3: Add bindings for CPR3+ driver
>       soc: qcom: cpr: Move common functions to new file
>       soc: qcom: cpr-common: Add support for flat fuse adjustment
>       soc: qcom: cpr-common: Add threads support
>       soc: qcom: Add a driver for CPR3+
>       arm64: dts: qcom: msm8998: Configure CPRh
>
> Konrad Dybcio (4):
>       MAINTAINERS: Include new Qualcomm CPR drivers in the file list
>       dt-bindings: opp: v2-qcom-level: Document CPR3 open/closed loop volt adjustment
>       dt-bindings: opp: v2-qcom-level: Allow opp-shared
>       soc: qcom: cpr: Use u64 for frequency
>

I have done a quick review of this series and looked a bit more at
patch9. Nothing that I found really stands out, so overall this looks
okay to me. Anyway, allow me to have a closer look, in particular at
patch9 in the next submitted version too.

One nitpick though, please update the prefix to "pmdomain: qcom*", for
those patches that belong to the pmdomain subsystem.

>  .../devicetree/bindings/opp/opp-v2-qcom-level.yaml |   16 +
>  .../devicetree/bindings/soc/qcom/qcom,cpr3.yaml    |  286 +++
>  MAINTAINERS                                        |    5 +-
>  arch/arm64/boot/dts/qcom/msm8998.dtsi              |  760 ++++++
>  drivers/pmdomain/qcom/Kconfig                      |   22 +
>  drivers/pmdomain/qcom/Makefile                     |    2 +
>  drivers/pmdomain/qcom/cpr-common.c                 |  362 +++
>  drivers/pmdomain/qcom/cpr-common.h                 |  109 +
>  drivers/pmdomain/qcom/cpr.c                        |  394 +--
>  drivers/pmdomain/qcom/cpr3.c                       | 2711 ++++++++++++++++++++
>  include/soc/qcom/cpr.h                             |   17 +
>  11 files changed, 4314 insertions(+), 370 deletions(-)
> ---
> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> change-id: 20230217-topic-cpr3h-de232bfb47ec
>
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>

Kind regards
Uffe