Re: [PATCH 0/8] pinctrl: Add T-Head TH1520 SoC pin controllers

[Linus Walleij]

On Tue, Sep 3, 2024 at 6:08 AM Drew Fustini <dfustini@xxxxxxxxxxxxxxx> wrote:

> This adds a pin control driver created by Emil for the T-Head TH1520
> RISC-V SoC used on the Lichee Pi 4A and BeagleV Ahead boards and
> updates the device trees to make use of it.
>
> Emil's series from January used separate compatibles for each pin
> controller instance. Rob did not think this was appropriate because the
> programming model is the same for each instance.
>
> This series takes a different approach. There is now only a single
> compatible for all pin controller instances. The pinctrl driver checks
> the unit address to identity which pin controller instance is being
> probed.

I don't know if that is a good way to do it, the unit name could change
for some reason and then the driver will not work, it seems fragile.

Can't we just add a custom property such as:
thead,pin-group-number = <2>;
to the device node?

Yours,
Linus Walleij